Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-instrumentation-redis): add condition before error printing #897

Merged

Conversation

haddasbronfman
Copy link
Member

Which problem is this PR solving?

  • The error: "Error executing responseHook" is printed without checking id an error did occur.

Short description of the changes

  • I added an 'if' condition before the printing

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #897 (2b24bbb) into main (d3883d3) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
- Coverage   95.91%   95.72%   -0.19%     
==========================================
  Files          13       16       +3     
  Lines         856     1007     +151     
  Branches      178      198      +20     
==========================================
+ Hits          821      964     +143     
- Misses         35       43       +8     
Impacted Files Coverage Δ
...e/opentelemetry-instrumentation-redis/src/utils.ts 93.10% <100.00%> (ø)
...metry-instrumentation-redis/src/instrumentation.ts 93.47% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.87% <0.00%> (ø)

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haddasbronfman, please enable Allow edits from maintainers so we can rebase and merge it ourselves.
Current errors have nothing to do with this PR and are fixed in the main.

@blumamir blumamir merged commit f1d2fd0 into open-telemetry:main Feb 21, 2022
This was referenced Feb 25, 2022
@chingor13 chingor13 mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants