Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a few packages to release config #873

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Feb 9, 2022

Which problem is this PR solving?

Release please doesn't release all packages.

Refs: #871

Short description of the changes

Added opentelemetry-propagation-utils, opentelemetry-instrumentation-fastify and opentelemetry-instrumentation-long-task to release config.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

Added opentelemetry-propagation-utils, opentelemetry-instrumentation-fastify and
opentelemetry-instrumentation-long-task to release config.
Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #873 (59ebb04) into main (ecd0307) will not change coverage.
The diff coverage is n/a.

❗ Current head 59ebb04 differs from pull request most recent head 080edb9. Consider uploading reports for the commit 080edb9 to get more accurate results

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          10       10           
  Lines         701      701           
  Branches      142      142           
=======================================
  Hits          668      668           
  Misses         33       33           

@vmarchaud vmarchaud merged commit fbceaf8 into open-telemetry:main Feb 9, 2022
@Flarna Flarna deleted the add-missing-packages branch February 9, 2022 17:00
@Flarna
Copy link
Member Author

Flarna commented Feb 9, 2022

It seems adding a package to release config doesn't trigger a release.
Looking into #871 it's maybe a good idea to trigger a release manually. Or do we need a dummy commit in fastify instrumentation to get this done?

@Flarna Flarna mentioned this pull request Feb 9, 2022
@dyladan
Copy link
Member

dyladan commented Feb 9, 2022

I think you actually need to add them to the manifest https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.release-please-manifest.json

@dyladan
Copy link
Member

dyladan commented Feb 9, 2022

There are 2 files for some reason. The manifest tracks the currently released versions and the config tracks where the packages exist in the directory tree

@Flarna
Copy link
Member Author

Flarna commented Feb 9, 2022

Hmm, I was doing the same as #840 did for tedious which was finally included by #815 and tedious was added in .release-please-manifest by the release main PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants