-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a few packages to release config #873
Conversation
Added opentelemetry-propagation-utils, opentelemetry-instrumentation-fastify and opentelemetry-instrumentation-long-task to release config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 10 10
Lines 701 701
Branches 142 142
=======================================
Hits 668 668
Misses 33 33 |
It seems adding a package to release config doesn't trigger a release. |
I think you actually need to add them to the manifest https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/.release-please-manifest.json |
There are 2 files for some reason. The manifest tracks the currently released versions and the config tracks where the packages exist in the directory tree |
Which problem is this PR solving?
Release please doesn't release all packages.
Refs: #871
Short description of the changes
Added opentelemetry-propagation-utils, opentelemetry-instrumentation-fastify and opentelemetry-instrumentation-long-task to release config.
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.