Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/setup-node action to v2 #857

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jan 28, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
actions/setup-node action major v1 -> v2

Release Notes

actions/setup-node

v2

Compare Source


Configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team January 28, 2022 00:26
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #857 (517b552) into main (3ee472d) will not change coverage.
The diff coverage is n/a.

❗ Current head 517b552 differs from pull request most recent head c2de3c2. Consider uploading reports for the commit c2de3c2 to get more accurate results

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          10       10           
  Lines         701      701           
  Branches      142      142           
=======================================
  Hits          668      668           
  Misses         33       33           

@renovate-bot renovate-bot force-pushed the renovate/actions-setup-node-2.x branch from 5ea5d2a to 701b9ae Compare January 31, 2022 13:52
@dyladan
Copy link
Member

dyladan commented Jan 31, 2022

Not all tests get run for these CI changes because the packages aren't changed so there's no real way to know if the tests would break.

edit: in the core repo, updating to v2 caused permissions issues

edit again: just saw this is for the release-please so it doesn't affect tests

@blumamir blumamir merged commit aedc7ff into open-telemetry:main Jan 31, 2022
@renovate-bot renovate-bot deleted the renovate/actions-setup-node-2.x branch January 31, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants