-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-sdk): add http status code attribute to aws sdk span #844
feat(aws-sdk): add http status code attribute to aws sdk span #844
Conversation
This PR is not ready for review because I couldn't run BTW - big like for the TAV in the checklist! |
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 95.29% 95.45% +0.15%
==========================================
Files 10 19 +9
Lines 701 1143 +442
Branches 142 240 +98
==========================================
+ Hits 668 1091 +423
- Misses 33 52 +19
|
plugins/node/opentelemetry-instrumentation-aws-sdk/src/aws-sdk.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Short description of the changes
http.status_code
attribute, as discussed in Ruby repo[AWS SDK Instrumentation] Trace does not report HTTP status in attributes opentelemetry-ruby#1094
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.