Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-sdk): add http status code attribute to aws sdk span #844

Merged

Conversation

YanivD
Copy link
Member

@YanivD YanivD commented Jan 21, 2022

Short description of the changes

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@YanivD
Copy link
Member Author

YanivD commented Jan 21, 2022

This PR is not ready for review because I couldn't run npm run test-all-versions.
I'll mark this PR as ready for review once I'll verify it pass successfully.

BTW - big like for the TAV in the checklist!

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #844 (a6b6219) into main (7032a33) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
+ Coverage   95.29%   95.45%   +0.15%     
==========================================
  Files          10       19       +9     
  Lines         701     1143     +442     
  Branches      142      240      +98     
==========================================
+ Hits          668     1091     +423     
- Misses         33       52      +19     
Impacted Files Coverage Δ
...opentelemetry-instrumentation-aws-sdk/src/enums.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <0.00%> (ø)
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.00% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)

@YanivD YanivD marked this pull request as ready for review January 23, 2022 11:25
@YanivD YanivD requested a review from a team January 23, 2022 11:25
Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@blumamir blumamir merged commit 09b8555 into open-telemetry:main Jan 24, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
@dyladan dyladan mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants