Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable TAV #823

Merged
merged 8 commits into from
Jan 20, 2022
Merged

feat: re-enable TAV #823

merged 8 commits into from
Jan 20, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jan 6, 2022

Which problem is this PR solving?

Had to temporarily disable TAV after some CI problems. Implementing some fixes and re-enabling it again.
After the discussion in SIG, the plan is:

Short description of the changes

  • removed change-detection - doesn't make sense for scheduled runs;
  • disable running on every PR - trust devs to do that locally;
  • add a reminder of ☝️ in the PR template;
  • run TAV setup scheduled;
  • run TAV setup on release PRs.
  • Figure out how to make TAV runs more visible - slack notifications, etc. We decided not to run those of every PR for now, but that might also render this workflow useless if no one regularly checks upon it. We'll take that on in the future.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #823 (d8512eb) into main (8ab7ddc) will decrease coverage by 1.27%.
The diff coverage is n/a.

❗ Current head d8512eb differs from pull request most recent head cfcc982. Consider uploading reports for the commit cfcc982 to get more accurate results

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   94.90%   93.62%   -1.28%     
==========================================
  Files          13       45      +32     
  Lines         707     2370    +1663     
  Branches      142      357     +215     
==========================================
+ Hits          671     2219    +1548     
- Misses         36      151     +115     
Impacted Files Coverage Δ
...lemetry-instrumentation-document-load/src/utils.ts
...etry-plugin-react-load/src/enums/AttributeNames.ts
...umentation-user-interaction/src/instrumentation.ts
...etapackages/auto-instrumentations-web/src/utils.ts
...strumentation-document-load/src/instrumentation.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
...ation-user-interaction/src/enums/AttributeNames.ts
...entation-document-load/src/enums/AttributeNames.ts
...entelemetry-instrumentation-long-task/test/util.ts
...entelemetry-instrumentation-fastify/src/version.ts
... and 48 more

@rauno56
Copy link
Member Author

rauno56 commented Jan 10, 2022

Status: tests for ioredis@4.28.1 fail.

@vmarchaud
Copy link
Member

Status: tests for ioredis@4.28.1 fail.

Is it flaky or just not working ? Seems weird that it doesn't work for node 16 but work for 8

@rauno56
Copy link
Member Author

rauno56 commented Jan 13, 2022

I'm not sure why, but the tests are actually not even running in node 8.

I think it's not flaky, but a bug. I just wanted to add a comment here for people who might have a question about why this is not moving along.

EDIT

It's surely a bug - first of all - tests assert stuff in hooks that have their errors eaten anyway. I'm surprised that the tests pass in some versions - that's another thing to look into.

@rauno56
Copy link
Member Author

rauno56 commented Jan 13, 2022

Submitted fixes with #830

@rauno56
Copy link
Member Author

rauno56 commented Jan 14, 2022

I'm afraid that running tests for packages concurrently doesn't work because of weird race conditions with lerna linking or something. Cryptic errors like "requ not defined" in the test-utils package.

@rauno56 rauno56 changed the title wip: feat: re-enable TAV feat: re-enable TAV Jan 17, 2022
@rauno56 rauno56 marked this pull request as ready for review January 17, 2022 08:57
@rauno56 rauno56 requested a review from a team January 17, 2022 08:57
@dyladan dyladan merged commit 2e14f46 into open-telemetry:main Jan 20, 2022
@rauno56 rauno56 deleted the feat/reenable-tav branch February 7, 2022 11:28
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants