-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-enable TAV #823
feat: re-enable TAV #823
Conversation
Status: tests for |
Is it flaky or just not working ? Seems weird that it doesn't work for node 16 but work for 8 |
I'm not sure why, but the tests are actually not even running in node 8. I think it's not flaky, but a bug. I just wanted to add a comment here for people who might have a question about why this is not moving along. EDIT It's surely a bug - first of all - tests assert stuff in hooks that have their errors eaten anyway. I'm surprised that the tests pass in some versions - that's another thing to look into. |
6623273
to
cf8cdbb
Compare
Submitted fixes with #830 |
I'm afraid that running tests for packages concurrently doesn't work because of weird race conditions with |
8f1eed9
to
2fb8c67
Compare
9763456
to
26131ec
Compare
Which problem is this PR solving?
Had to temporarily disable TAV after some CI problems. Implementing some fixes and re-enabling it again.
After the discussion in SIG, the plan is:
Short description of the changes