Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis instrumentation startup stream check #666 #818

Merged
merged 12 commits into from
Jan 5, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jan 4, 2022

Which problem is this PR solving?

All work done by @jonbcampos-alto in #666 👿

Short description of the changes

Added the fix for the lint and recreated the PR to close #666 and get the fix merged.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #818 (badb726) into main (cf268e7) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head badb726 differs from pull request most recent head 53753fa. Consider uploading reports for the commit 53753fa to get more accurate results

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   94.91%   94.99%   +0.08%     
==========================================
  Files          14       20       +6     
  Lines         708     1059     +351     
  Branches      142      170      +28     
==========================================
+ Hits          672     1006     +334     
- Misses         36       53      +17     
Impacted Files Coverage Δ
...ages/auto-instrumentations-node/test/utils.test.ts 96.87% <0.00%> (ø)
...metry-instrumentation-redis/src/instrumentation.ts 93.47% <0.00%> (ø)
...entelemetry-instrumentation-fastify/src/version.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 96.77% <0.00%> (ø)
...e/opentelemetry-instrumentation-redis/src/utils.ts 92.98% <0.00%> (ø)
...telemetry-instrumentation-redis/test/redis.test.ts 95.65% <0.00%> (ø)

@rauno56
Copy link
Member Author

rauno56 commented Jan 5, 2022

Enough people approved #666, so I'll take the freedom to merge this.

@rauno56 rauno56 merged commit 81b3190 into open-telemetry:main Jan 5, 2022
@rauno56 rauno56 deleted the jonbcampos-alto/main branch January 5, 2022 15:29
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants