-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use localhost for services in CI #816
fix: use localhost for services in CI #816
Conversation
Codecov Report
@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 94.91% 94.71% -0.21%
==========================================
Files 14 154 +140
Lines 708 12175 +11467
Branches 142 1176 +1034
==========================================
+ Hits 672 11531 +10859
- Misses 36 644 +608
|
I switched from containers to node when I updated We can go back to running in node containers, but we will need to solve the permission issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this because it solves our immediate problem of tests failing but we should look into container tests again
Which problem is this PR solving?
The services in CI are not currently accessible.
The hostnames do not resolve because the step execution was recently moved from containers(which belong to the bridge network where the service names resolve) to the runner machine.
See c69c202 - @dyladan
The docs:
The above section from the docs makes total sense, however, I'm personally not clear on why is
actions/setup-node@v2
the recommended way to run node - it pollutes the runner machine and comes with an additional layer of caching.Short description of the changes
Since just swapping back to running in a container, results in some FS permission issues, I'm just changing the hostnames to use to localhost.
That means the TAV setup is broken as well. I'd make the same change to it, but seeing that it doesn't set up node, I cannot see how it could work even with the services being accessible. I'll disable it for now.
Sorted the keywords in the packages mainly to trigger a change for Lerna for all the packages.