Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-resource-detector-aws): add missing attribute to la… #810

Conversation

anupamdalmia10
Copy link
Contributor

Signed-off-by: Anupam Dalmia anupamdalmia10@users.noreply.github.com

Which problem is this PR solving?

  • Cloud Platform value in AWS Lambda detector was missing, it is there for other detectors.

Short description of the changes

  • Added the Cloud Platform value for AWS Lambda from semantic-conventions package.

…mbda detector

Signed-off-by: Anupam Dalmia <anupamdalmia10@users.noreply.github.com>
@anupamdalmia10 anupamdalmia10 requested a review from a team December 31, 2021 09:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 31, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #810 (6ae2ecc) into main (b5a648f) will increase coverage by 1.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   94.91%   96.06%   +1.14%     
==========================================
  Files          14       26      +12     
  Lines         708     1244     +536     
  Branches      142      163      +21     
==========================================
+ Hits          672     1195     +523     
- Misses         36       49      +13     
Impacted Files Coverage Δ
...ce-detector-aws/src/detectors/AwsLambdaDetector.ts 100.00% <ø> (ø)
...or-aws/test/detectors/AwsBeanstalkDetector.test.ts 100.00% <0.00%> (ø)
...detector-aws/test/detectors/AwsEksDetector.test.ts 100.00% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEcsDetector.ts 100.00% <0.00%> (ø)
...detector-aws/src/detectors/AwsBeanstalkDetector.ts 95.65% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEc2Detector.ts 97.91% <0.00%> (ø)
...detector-aws/test/detectors/AwsEcsDetector.test.ts 100.00% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEksDetector.ts 91.25% <0.00%> (ø)
...entelemetry-instrumentation-fastify/src/version.ts 0.00% <0.00%> (ø)
... and 3 more

@dyladan dyladan merged commit 359fee8 into open-telemetry:main Jan 3, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants