Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fix React Load plugin example #800

Merged
merged 4 commits into from
Dec 30, 2021

Conversation

kkhaidukov
Copy link
Contributor

Which problem is this PR solving?

  • I wasn't able to run the React Load plugin example, this PR fixes that

Short description of the changes

  • updates the config
  • uses a more recent version of opentelemetry-collector-contrib
  • adds missing dependencies
  • updates the README
  • sets the service name for the example

@kkhaidukov kkhaidukov requested a review from a team December 28, 2021 17:40
@linux-foundation-easycla
Copy link

CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Not Signed

@linux-foundation-easycla
Copy link

CLA Not Signed

@vmarchaud vmarchaud added the bug Something isn't working label Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #800 (cff7f1e) into main (2c4a834) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          14       14           
  Lines         708      708           
  Branches      142      142           
=======================================
  Hits          672      672           
  Misses         36       36           

@vmarchaud vmarchaud merged commit fff013c into open-telemetry:main Dec 30, 2021
@kkhaidukov kkhaidukov deleted the fix-react-load-example branch December 30, 2021 14:06
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants