Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow mysql streamable query with values array #790

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

mwear
Copy link
Member

@mwear mwear commented Dec 18, 2021

Which problem is this PR solving?

Short description of the changes

  • The logic in patch query has been simplified such that if there is a callback present in the call to query it patches the callback to end the span, otherwise, it registers an on('end') listener to end the span.

@mwear mwear requested a review from a team December 18, 2021 00:21
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #790 (6e3f7d4) into main (ac62c0a) will increase coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #790      +/-   ##
==========================================
+ Coverage   94.90%   96.21%   +1.30%     
==========================================
  Files          13       18       +5     
  Lines         707     1399     +692     
  Branches      142      182      +40     
==========================================
+ Hits          671     1346     +675     
- Misses         36       53      +17     
Impacted Files Coverage Δ
...telemetry-instrumentation-mysql/test/index.test.ts 98.55% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 96.77% <0.00%> (ø)
...e/opentelemetry-instrumentation-mysql/src/utils.ts 100.00% <0.00%> (ø)
...ages/auto-instrumentations-node/test/utils.test.ts 96.87% <0.00%> (ø)
...metry-instrumentation-mysql/src/instrumentation.ts 93.33% <0.00%> (ø)

@rauno56 rauno56 merged commit 88db0a4 into open-telemetry:main Jan 14, 2022
@dyladan dyladan mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL Instrumentation - Bug with streaming query and multiple parameters
3 participants