Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test multiple versions of pg and pg-pool #751

Merged
merged 9 commits into from
Nov 30, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Nov 22, 2021

Which problem is this PR solving?

We claim support for 7.x and 8.x, but don't test to ensure that. Adding tests.

Short description of the changes

I'm adding TAV(test-all-versions package) setup for pg in this PR to test the most popular versions across the supported range:

  • 7.3.0 - errors on connecting to postgres v14, narrowing down the test-utils version to avoid contributors running into the same issue.
  • 7.12.1
  • 7.18.2
  • 8.5.1
  • 8.6.0
  • 8.7.1

7.x branch does not work with node 14+. I'm disabling TAV runs on those versions. npm run test still runs whatever the node version is.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #751 (0c8522d) into main (bdfbcd4) will decrease coverage by 1.65%.
The diff coverage is 81.81%.

❗ Current head 0c8522d differs from pull request most recent head 24ba89e. Consider uploading reports for the commit 24ba89e to get more accurate results

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   96.87%   95.22%   -1.66%     
==========================================
  Files          11       73      +62     
  Lines         640     6239    +5599     
  Branches      126      615     +489     
==========================================
+ Hits          620     5941    +5321     
- Misses         20      298     +278     
Impacted Files Coverage Δ
...e/opentelemetry-instrumentation-pg/test/pg.test.ts 94.13% <72.72%> (ø)
...ntelemetry-instrumentation-pg/test/pg-pool.test.ts 90.21% <75.00%> (ø)
...ode/opentelemetry-instrumentation-pg/test/utils.ts 90.47% <90.47%> (ø)
...y-instrumentation-cassandra/src/instrumentation.ts 80.37% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 96.91% <0.00%> (ø)
...urce-detector-alibaba-cloud/src/detectors/index.ts 100.00% <0.00%> (ø)
...detector-aws/src/detectors/AwsBeanstalkDetector.ts 95.65% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...pentelemetry-instrumentation-pg/test/utils.test.ts 98.36% <0.00%> (ø)
...etry-instrumentation-aws-sdk/test/dynamodb.test.ts 100.00% <0.00%> (ø)
... and 54 more

@rauno56 rauno56 force-pushed the chore/pg-version-tests branch 2 times, most recently from a95e8f9 to 426c722 Compare November 24, 2021 14:08
@rauno56 rauno56 marked this pull request as ready for review November 24, 2021 16:42
@rauno56 rauno56 requested a review from a team November 24, 2021 16:42
... since there's none for pg.
@rauno56 rauno56 changed the title chore: test more versions of pg and pg-pool test: test multiple versions of pg and pg-pool Nov 26, 2021
@dyladan dyladan merged commit 92221ba into open-telemetry:main Nov 30, 2021
@rauno56 rauno56 deleted the chore/pg-version-tests branch November 30, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants