Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint to v8 #699

Merged
merged 7 commits into from
Jan 31, 2022
Merged

chore(deps): update dependency eslint to v8 #699

merged 7 commits into from
Jan 31, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 15, 2021 •
edited
Loading

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 7.32.0 -> 8.7.0 age adoption passing confidence

Release Notes

eslint/eslint

v8.7.0

Compare Source

Features

  • 19ad061 feat: no-restricted-imports support casing (#​15439) (gfyoung)
  • 564ecdb feat: Support arbitrary module namespace names in no-restricted-imports (#​15491) (Milos Djermanovic)
  • 968a02a feat: Support arbitrary module namespace names in no-useless-rename (#​15493) (Milos Djermanovic)
  • 0d2b9a6 feat: move eslint --init to @​eslint/create-config (#​15150) (唯然)
  • 127f524 feat: false negative with property option in id-match (#​15474) (Nitin Kumar)
  • 359b2c1 feat: Support arbitrary module namespace names in the camelcase rule (#​15490) (Milos Djermanovic)
  • 3549571 feat: Support arbitrary module namespace names in the quotes rule (#​15479) (Milos Djermanovic)
  • 5563c45 feat: Support arbitrary module namespace names in keyword-spacing (#​15481) (Milos Djermanovic)
  • fd3683f feat: Support arbitrary module namespace names in no-restricted-exports (#​15478) (Milos Djermanovic)

Bug Fixes

  • a8db9a5 fix: no-invalid-this false positive in class field initializer (#​15495) (Milos Djermanovic)
  • 02d6426 fix: Correctly consume RuleTester statics (#​15507) (Brad Zacher)
  • db15802 fix: Add property fatalErrorCount to ignored file results (#​15520) (Francesco Trotta)
  • 03ac8cf fix: Prevent false positives with no-constant-condition (#​15486) (Jordan Eldredge)

Documentation

  • f50f849 docs: Update CLI docs to prefer local install (#​15513) (Nicholas C. Zakas)
  • 0469eb1 docs: Update shell code fences for new website (#​15522) (Olga)

Chores

v8.6.0

Compare Source

Features

  • 6802a54 feat: handle logical assignment in no-self-assign (#​14152) (Zzzen)
  • 3b38018 feat: allow to define eslint-disable-next-line in multiple lines (#​15436) (Nitin Kumar)
  • 9d6fe5a feat: false negative with onlyDeclarations + properties in id-match (#​15431) (Nitin Kumar)

Documentation

Chores

  • 3a384fc chore: Upgrade espree to 9.3.0 (#​15473) (Brandon Mills)
  • 1443cc2 chore: Update blogpost.md.ejs (#​15468) (Nicholas C. Zakas)
  • 28e907a refactor: remove unused parameter in linter.js (#​15451) (Milos Djermanovic)
  • eaa08d3 test: add tests for allowReserved parser option with flat config (#​15450) (Milos Djermanovic)

v8.5.0

Compare Source

Features

Bug Fixes

  • 7d832d4 fix: improve prefer-template fixer (#​15230) (Nitin Kumar)
  • 981fb48 fix: do not report global references in id-match rule (#​15420) (Nitin Kumar)
  • f13d4a6 fix: improve autofix of prefer-object-has-own (#​15419) (Nitin Kumar)
  • f4559a0 fix: add helpful message when test case has non-string code/name (#​15425) (Bryan Mishkin)

Documentation

  • 314c84c docs: add an incorrect code example in for-direction (#​15434) (Holger Jeromin)
  • 3928175 docs: add destructuring examples for computed-property-spacing (#​15423) (Nitin Kumar)
  • a53e59e docs: add more examples for array-element-newline rule (#​15427) (Nitin Kumar)
  • 74cf0a0 docs: update CLA info (#​15370) (Nitin Kumar)
  • e84195e docs: fix heading level for an option in class-methods-use-this rule (#​15399) (Takuya Fukuju)

Chores

  • 225f211 test: add destructuring test cases for computed-property-spacing (#​15424) (Nitin Kumar)
  • f2c7ba6 ci: use node v16 for macOS and windows jobs (#​15418) (Nitin Kumar)

v8.4.1

Compare Source

Bug Fixes

  • 234e3d9 fix: revert changes to reported locations in max-lines-per-function (#​15397) (Milos Djermanovic)

Documentation

  • fa4d483 docs: fix typo in example for sort-keys rule (#​15393) (Nitin Kumar)

v8.4.0

Compare Source

Features
Bug Fixes
  • 4940cc5 fix: mark --rulesdir option as deprecated in CLI docs (#​15310) (Kevin Partington)
Documentation
  • 54deec5 docs: update integrations.md (#​15380) (Vlad Sholokhov)
  • fa0423a docs: fix typo in PR template (#​15365) (Nitin Kumar)
  • e233920 docs: enable a few more markdownlint rules and fix violations (#​15368) (Bryan Mishkin)
  • 632176d docs: Dedent needlessly indented example in getter-return docs (#​15363) (Jordan Eldredge)
  • 4497e88 docs: Update release notes blog post template (#​15285) (Nicholas C. Zakas)
Chores

v8.3.0

Compare Source

Features
  • 60b0a29 feat: add allowProperties option to require-atomic-updates (#​15238) (Milos Djermanovic)
  • 79278a1 feat: update no-use-before-define for class static blocks (#​15312) (Milos Djermanovic)
  • ddd01dc feat: update no-redeclare for class static blocks (#​15313) (Milos Djermanovic)
  • de69cec feat: update no-inner-declarations for class static blocks (#​15290) (Milos Djermanovic)
  • e2fe7ef feat: support for private-in syntax (fixes #​14811) (#​15060) (Yosuke Ota)
  • 34bc8d7 feat: Update espree and eslint-scope (#​15338) (Brandon Mills)
  • b171cd7 feat: update max-depth for class static blocks (#​15316) (Milos Djermanovic)
  • 6487df3 feat: update padded-blocks for class static blocks (#​15333) (Milos Djermanovic)
  • 194f36d feat: update the complexity rule for class static blocks (#​15328) (Milos Djermanovic)
  • 3530337 feat: update the indent rule for class static blocks (#​15324) (Milos Djermanovic)
  • f03cd14 feat: update lines-around-comment for class static blocks (#​15323) (Milos Djermanovic)
  • 5c64747 feat: update brace-style for class static blocks (#​15322) (Milos Djermanovic)
  • df2f1cc feat: update max-statements for class static blocks (#​15315) (Milos Djermanovic)
  • fd5a0b8 feat: update prefer-const for class static blocks (#​15325) (Milos Djermanovic)
  • b3669fd feat: code path analysis for class static blocks (#​15282) (Milos Djermanovic)
  • 15c1397 feat: update eslint-scope for class static blocks (#​15321) (Milos Djermanovic)
  • 1a1bb4b feat: update one-var for class static blocks (#​15317) (Milos Djermanovic)
  • 9b666e0 feat: update padding-line-between-statements for class static blocks (#​15318) (Milos Djermanovic)
  • d3a267f feat: update class-methods-use-this for class static blocks (#​15298) (Milos Djermanovic)
  • cdaa541 feat: update no-lone-blocks for class static blocks (#​15295) (Milos Djermanovic)
  • 8611538 feat: update block-spacing for class static blocks (#​15297) (Milos Djermanovic)
  • 7b56844 feat: update keyword-spacing for class static blocks (#​15289) (Milos Djermanovic)
  • ea18711 feat: update no-extra-semi for class static blocks (#​15287) (Milos Djermanovic)
  • 0f0971f feat: update semi rule for class static blocks (#​15286) (Milos Djermanovic)
  • abe740c feat: add examples for block-scoped-var with class static blocks (#​15302) (Milos Djermanovic)
  • 0338fd2 feat: Normalize ecmaVersion to eslint-scope when using custom parser (#​15268) (Yosuke Ota)
Bug Fixes
  • 8aa7645 fix: update vars-on-top for class static blocks (#​15306) (Milos Djermanovic)
  • 479a4cb fix: update semi-style for class static blocks (#​15309) (Milos Djermanovic)
  • 6d1c666 fix: update no-invalid-this and no-eval for class static blocks (#​15300) (Milos Djermanovic)
Documentation
  • 6b85426 docs: Expand --debug option description in the CLI documentation (#​15308) (darkred)
  • 3ae5258 docs: the strict rule does not apply to class static blocks (#​15314) (Milos Djermanovic)
  • 9309841 docs: Remove inconsistent colon in pull request docs (#​15303) (Jordan Eldredge)
  • da238cc docs: remove deprecation note from lines-around-comment (#​15293) (Milos Djermanovic)
  • 1055f16 docs: no-unused-expressions - class static blocks don't have directives (#​15283) (Milos Djermanovic)
  • 4c55216 docs: Add variables option to no-use-before-define (#​15276) (Mathias Rasmussen)
Chores
  • edd8d24 chore: upgrade eslint-visitor-keys for class static blocks (#​15277) (Milos Djermanovic)

v8.2.0

Compare Source

Features

  • c9fefd2 feat: report class evaluation TDZ errors in no-use-before-define (#​15134) (Milos Djermanovic)

Documentation

  • c415c04 docs: Use string rule severity in CLI examples (#​15253) (Kevin Partington)
  • 12b627d docs: fix typo in working-with-rules.md (#​15233) (Nitin Kumar)
  • a86ffc0 docs: fix broken anchor in configuration files (#​15223) (Pierre Berger)
  • ee8af5f docs: Link to unit tests from rule documentation (#​15207) (Brandon Mills)
  • 1c0ca3c docs: add ci and perf tags for commit (#​15215) (Nitin Kumar)

Build Related

  • 796587a build: upgrade eslint-release to v3.2.0 to support conventional commits (#​15246) (Milos Djermanovic)

Chores

v8.1.0

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

Configuration

📅 Schedule: "before 3am on Friday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team October 15, 2021 01:31
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #699 (9220bc5) into main (5cb3266) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   95.29%   95.06%   -0.23%     
==========================================
  Files          10       25      +15     
  Lines         701     1256     +555     
  Branches      142      260     +118     
==========================================
+ Hits          668     1194     +526     
- Misses         33       62      +29
Impacted Files Coverage Δ
...etry-instrumentation-aws-sdk/src/services/index.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.36% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 100.00% <0.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <0.00%> (ø)
...extension-autoinjection/src/contentScript/index.ts 0.00% <0.00%> (ø)
...metry-browser-extension-autoinjection/src/types.ts 90.32% <0.00%> (ø)
...entation-aws-sdk/src/services/MessageAttributes.ts 90.32% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 89.65% <0.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 93.75% <0.00%> (ø)
... and 5 more

@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 2 times, most recently from 13fc822 to 11bf775 Compare October 23, 2021 00:03
@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 2 times, most recently from 9bb7c3a to e8d042c Compare November 12, 2021 10:30
@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 2 times, most recently from ecc286d to b065407 Compare December 4, 2021 04:54
@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 2 times, most recently from 1ac3b7f to bf14c5b Compare December 21, 2021 15:02
@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 13 times, most recently from cf5fda3 to ba0fc40 Compare January 11, 2022 18:03
@renovate-bot renovate-bot force-pushed the renovate/eslint-8.x branch 9 times, most recently from 2d9a302 to 8fe1978 Compare January 14, 2022 13:34
@rauno56
Copy link
Member

rauno56 commented Jan 14, 2022 •
edited
Loading

eslint@8 drops support for node v10: eslint/eslint#14592
Make sure we only run the linting step with never versions.

@dyladan
Copy link
Member

dyladan commented Jan 14, 2022

I think we run it with 12 or 14 can't remember

@blumamir
Copy link
Member

In CI it's run with 14.
Does that mean that contributors with node 10 will not be able to run npm run lint:fix locally?

@vmarchaud
Copy link
Member

Does that mean that contributors with node 10 will not be able to run npm run lint:fix locally?

Yes but i think its acceptable since its EOL since April 2021

blumamir
blumamir approved these changes Jan 26, 2022
View reviewed changes
packages/opentelemetry-browser-extension-autoinjection/package.json
@@ -39,7 +39,7 @@
"@typescript-eslint/parser": "5.8.1",
"codecov": "3.8.3",
"colors": "1.4.0",
"eslint": "7.32.0",
"eslint": "8.7.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to the version bump, but should we remove eslint dependency and other eslint related packages from the subpackages, and keep it only in root?

    "@typescript-eslint/eslint-plugin": "5.8.1",
    "@typescript-eslint/parser": "5.8.1",
    "eslint": "7.32.0",
    "eslint-config-airbnb-base": "14.2.1",
    "eslint-plugin-header": "3.1.1",
    "eslint-plugin-import": "2.23.4",
    "eslint-plugin-json5": "0.1.3",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we can since the deps aren't hoisted, this would mean that you couldn't run eslint independently for a specific repo ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is only specified on browser-extension-autoinject and instrumentation-aws-sdk.
If it's needed per package then we should also add it to all other packages in the repo, but I think it's better to configure and run lint on the entire repo from the root, and not per package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser-extension-autoinject use eslint-plugin-json5.
I believe it can be hoisted to the repo root.

@blumamir blumamir merged commit 3ee472d into open-telemetry:main Jan 31, 2022
@renovate-bot renovate-bot deleted the renovate/eslint-8.x branch January 31, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blumamir blumamir blumamir approved these changes

@YanivD YanivD YanivD approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

Assignees

@obecny obecny

@dyladan dyladan

@mayurkale22 mayurkale22

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@renovate-bot @rauno56 @dyladan @blumamir @vmarchaud @YanivD @obecny @mayurkale22