Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: winston instrumentation #425

Merged
merged 7 commits into from
Apr 19, 2021
Merged

feat: winston instrumentation #425

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b096f61
feat: winston instrumentation
seemk Apr 14, 2021
387fd62
feat: add support for Winston 2
seemk Apr 15, 2021
3f49618
refactor: remove leftover console logs
seemk Apr 15, 2021
147048e
Merge branch 'main' into winston
seemk Apr 17, 2021
abb9ce4
Merge branch 'main' into winston
seemk Apr 19, 2021
74cf876
Merge branch 'winston' of github.com:seemk/opentelemetry-js-contrib i…
seemk Apr 19, 2021
63ea62e
Merge branch 'main' into winston
vmarchaud Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove leftover console logs
  • Loading branch information
@seemk
seemk committed Apr 15, 2021
commit 3f4961839922f82145b4896271b9c03f04003992
4 changes: 0 additions & 4 deletions plugins/node/opentelemetry-instrumentation-winston/src/winston.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,17 +185,13 @@ export class WinstonInstrumentation extends InstrumentationBase {
}

const record = injectRecord(spanContext);
console.log(record);

const insertAt =
typeof args[args.length - 1] === 'function'
? args.length - 1
: args.length;
console.log(insertAt);
console.log(args);

args.splice(insertAt, 0, record);
console.log(args);
instrumentation._callHook(span, record);

return original.apply(this, args);
Expand Down