feat(instrumentation-ioredis): add response hook for custom attributes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 12 12
Lines 409 409
Branches 45 45
=======================================
Hits 384 384
Misses 25 25 |
vmarchaud
reviewed
Feb 10, 2021
plugins/node/opentelemetry-instrumentation-ioredis/src/utils.ts
Outdated
Show resolved
Hide resolved
vmarchaud
reviewed
Feb 10, 2021
| } | ||
| safeExecuteInTheMiddle( | ||
| () => config?.responseHook?.(span, cmd.name, cmd.args, result), | ||
| () => {}, |
There was a problem hiding this comment.
Sorry i didn't catch this before but i think it could be better if we could log an error so the user know that its hook is failing
There was a problem hiding this comment.
makes sense. added logging on error :)
Flarna
reviewed
Feb 10, 2021
plugins/node/opentelemetry-instrumentation-ioredis/src/types.ts
Outdated
Show resolved
Hide resolved
Flarna
approved these changes
Feb 10, 2021
vmarchaud
approved these changes
Feb 15, 2021
obecny
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was originally sent in this PR, and I was asked to split it into a different PR. Now that the original PR is merged, I am able to send it once again.
Which problem is this PR solving?
This is similar to the hooks functions in instrumentation-http, and to the plugins in this repo (which I maintain).
Possible usage: add a custom attribute to span which tells if the command is a key HIT or key MISS.
Short description of the changes
IORedisInstrumentationConfig, and call the function when the command is successfullyresolved.