Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub Actions Resource Detector #265

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

smithclay
Copy link
Contributor

Which problem is this PR solving?

Originally a PR open-telemetry/opentelemetry-js#1681, moved to this repo after discussion.

Short description of the changes

  • Detects GitHub-specific environment variables (i.e. GITHUB_SHA, GITHUB_REF) in Action runners and adds them as resource attributes if they exist.
  • Adds new directory structure for resource detectors.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #265 (d3dcada) into master (f039f1f) will increase coverage by 0.01%.
The diff coverage is 96.22%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   94.94%   94.95%   +0.01%     
==========================================
  Files         110      115       +5     
  Lines        5937     5990      +53     
  Branches      617      618       +1     
==========================================
+ Hits         5637     5688      +51     
- Misses        300      302       +2     
Impacted Files Coverage Δ
...pentelemetry-resource-detector-github/.eslintrc.js 0.00% <0.00%> (ø)
...ntelemetry-resource-detector-github/src/version.ts 0.00% <0.00%> (ø)
...ce-detector-github/src/detectors/GitHubDetector.ts 100.00% <100.00%> (ø)
...ry-resource-detector-github/src/detectors/index.ts 100.00% <100.00%> (ø)
...ector-github/test/detectors/GitHubDetector.test.ts 100.00% <100.00%> (ø)

@obecny obecny added the enhancement New feature or request label Dec 14, 2020
@obecny obecny merged commit 12749ae into open-telemetry:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants