-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-document-load): check if getEntriesByType is available before using it #259
fix(plugin-document-load): check if getEntriesByType is available before using it #259
Conversation
getEntriesByType is available before using it
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 110 110
Lines 5888 5888
Branches 607 609 +2
=======================================
Hits 5598 5598
Misses 290 290
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for contribution
Any idea when this will get merged? |
@mhennoch we cannot merge until you sign the CLA |
@obecny I signed it after it initially failed. Under checks it says: |
it was marked as not signed, until you commented on PR then the CLA check is run again, now I see it is fine |
Which problem is this PR solving?
Short description of the changes