Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix baggage span processor NPM links #2185

Merged

Conversation

MikeGoldsmith
Copy link
Member

Which problem is this PR solving?

Fixes the NPM links in the Baggage Span Processor README.

Short description of the changes

  • Update the img and url links in README

@MikeGoldsmith MikeGoldsmith requested a review from a team May 8, 2024 11:05
@MikeGoldsmith MikeGoldsmith changed the title Fix baggage span processor NPM links chore: Fix baggage span processor NPM links May 8, 2024
@MikeGoldsmith MikeGoldsmith changed the title chore: Fix baggage span processor NPM links docs: Fix baggage span processor NPM links May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (9d11b90).
Report is 108 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2185      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.51%     
==========================================
  Files         146      149       +3     
  Lines        7492     7592     +100     
  Branches     1502     1591      +89     
==========================================
+ Hits         6816     6869      +53     
- Misses        676      723      +47     

see 35 files with indirect coverage changes

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks Mike!

@JamieDanielson JamieDanielson merged commit c1c3650 into open-telemetry:main May 8, 2024
16 of 17 checks passed
@JamieDanielson JamieDanielson deleted the mike/baggage-readme branch May 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants