Skip to content

Conversation

@JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add back test for ESM support in pino instrumentation, which was inadvertently dropped in a separate PR

@JamieDanielson JamieDanielson requested a review from a team May 3, 2024 21:53
@github-actions github-actions bot requested a review from seemk May 3, 2024 21:53
@codecov
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (1f58b07).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.51%     
==========================================
  Files         146      149       +3     
  Lines        7492     7592     +100     
  Branches     1502     1591      +89     
==========================================
+ Hits         6816     6869      +53     
- Misses        676      723      +47     

see 35 files with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented May 6, 2024

Thanks for re-adding this!

@JamieDanielson JamieDanielson merged commit 66e6ce4 into open-telemetry:main May 7, 2024
@JamieDanielson JamieDanielson deleted the jamie.esm-pino-add-test branch May 7, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants