Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(propagator-aws-xray): Remove Xray propagator package #2106

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

martinkuba
Copy link
Contributor

Removing the xray propagator from this repository is part of open-telemetry/opentelemetry-js#4494. The package has already been added to the core SDK repository (open-telemetry/opentelemetry-js#4603).

@martinkuba martinkuba requested a review from a team April 16, 2024 23:51
@martinkuba martinkuba changed the title Remove Xray propagator package refactor(propagator-aws-xray): Remove Xray propagator package Apr 16, 2024
@Flarna
Copy link
Member

Flarna commented Apr 17, 2024

I think .release-please-manifest.json and release-please-config.json should be also adapted.
Not sure about package-lock.json in root folder. If it is not autogenerated it's likely best to remove also the xray propagator entries there.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Merging #2106 (fb1acac) into main (dfb2dff) will decrease coverage by 0.32%.
Report is 56 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2106      +/-   ##
==========================================
- Coverage   90.97%   90.66%   -0.32%     
==========================================
  Files         146      147       +1     
  Lines        7492     7584      +92     
  Branches     1502     1517      +15     
==========================================
+ Hits         6816     6876      +60     
- Misses        676      708      +32     

see 9 files with indirect coverage changes

@trentm
Copy link
Contributor

trentm commented Apr 17, 2024

We should remember to remove the pkg:propagator-aws-xray label on this repo afterwards.

@trentm
Copy link
Contributor

trentm commented Apr 17, 2024

Not sure about package-lock.json in root folder. If it is not autogenerated it's likely best to remove also the xray propagator entries there.

The package-lock change looks good.

@pichlermarc pichlermarc merged commit d5e0d65 into open-telemetry:main Apr 18, 2024
15 checks passed
@pichlermarc
Copy link
Member

We should remember to remove the pkg:propagator-aws-xray label on this repo afterwards.

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants