Skip to content

test(instr-express): add test for ESM #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2024
Merged

test(instr-express): add test for ESM #1966

merged 4 commits into from
Mar 5, 2024

Conversation

@JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add test for ESM support in express instrumentation

@JamieDanielson JamieDanielson requested a review from a team February 27, 2024 15:51
@github-actions github-actions bot requested a review from pkanal February 27, 2024 15:51
@JamieDanielson JamieDanielson changed the title maint(instr-express): add test for ESM test(instr-express): add test for ESM Feb 27, 2024
@codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

Merging #1966 (7d72154) into main (43fd4eb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1966   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files         146      146           
  Lines        7492     7492           
  Branches     1501     1501           
=======================================
  Hits         6820     6820           
  Misses        672      672

pichlermarc
pichlermarc approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this. 🙂

trentm
trentm approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, with a possible suggestion to avoid the current Router issue/limitation.

@JamieDanielson JamieDanielson mentioned this pull request Mar 5, 2024
Closed
@JamieDanielson JamieDanielson merged commit 7106313 into open-telemetry:main Mar 5, 2024
@JamieDanielson JamieDanielson deleted the jamie.express-esm-test branch March 5, 2024 21:11
@JamieDanielson JamieDanielson mentioned this pull request Mar 5, 2024
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trentm trentm trentm approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

@pkanal pkanal Awaiting requested review from pkanal

Assignees

@pkanal pkanal

@JamieDanielson JamieDanielson

Labels

pkg:instrumentation-express

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JamieDanielson @trentm @pichlermarc @pkanal