-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add non-releasing packages to release-please config so their local deps get bumped #1928
chore: add non-releasing packages to release-please config so their local deps get bumped #1928
Conversation
…al deps get bumped This is option 1 from open-telemetry#1917. Refs: open-telemetry#1917
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1928 +/- ##
=======================================
Coverage 91.02% 91.02%
=======================================
Files 146 146
Lines 7478 7478
Branches 1497 1497
=======================================
Hits 6807 6807
Misses 671 671 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might also need to add it to the manifest file
My initial naive guess was that with FWIW, here is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking care of this 👍
I also think that should be fine if we don't add these to the manifest file. Let's try without it, adding it later should be an easy fix if it's needed. |
…s to release-please config) from open-telemetry#1928
…in release-please release PRs This continues on from open-telemetry#1928. The non-releasing packages are being added to the release-please manifest in the hope that this prevents them from being listed in the set of released packages in a release-please PR. This is effectively Option 1b from open-telemetry#1917.
…in release-please release PRs (#1939) This continues on from #1928. The non-releasing packages are being added to the release-please manifest in the hope that this prevents them from being listed in the set of released packages in a release-please PR. This is effectively Option 1b from #1917. Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
…s to release-please config) from open-telemetry#1928
* chore: remove the non-publishing packages from the npm workspace Because they cause difficulties with updating `@opentelemetry/*` dependencies. This is "Option 3" from #1917 Refs: #1917 * undo #1917 option 1 work (adding non-publishing packages to release-please config) from #1928 * move express example (haven't adjusted build / docs yet) * express example updates to get it working * remove non-publishing packages from release-please manifest * move koa example * fix up the koa-example-related files * move the mongodb/examples files to the top-level * fixup the mongodb-example files * move mysql-example files * fixup the mysql-example files * move redis-example files to top level examples/ dir * fixup redis-example files * update examples README to no longer suggest moving to instruemtnation package dirs * regenerate package-lock.json to rm the '.../examples' dir entries 'npm install --package-lock-only' did not accomplish this. This regen was necessary because those vestigial entries caused surprising breakage in some 'npm install --no-save ...' commands such as TAV is doing. It broke TAV tests with mongodb@4.17.1. * compile:examples is no longer a thing * fix for 'npm ci' failures imported from PR #1955 * regenerate package-lock.json 'undici-types', required by the version of @types/node used by the new instrumentation-perf-hooks, was lost in the merge from main. * add some more test output information to try to help debug flaky test * fix tweaks to the test * undo the instr-perf-hooks test assert tweaks, leaving that to a separate PR
This is option 1 from #1917.
Closes: #1917