Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentelemetry-plugin-pg): omit pg.values by default #174

Merged
merged 5 commits into from
Aug 18, 2020
Merged

feat(opentelemetry-plugin-pg): omit pg.values by default #174

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
925b9ad
refactor(opentelemetry-plugin-pg): fix eslint warnings
sergioregueira Aug 15, 2020
28133c6
refactor(opentelemetry-plugin-pg): do not intersect types all the time
sergioregueira Aug 15, 2020
c5ef7de
refactor(opentelemetry-plugin-pg): rename interface to reduce confusion
sergioregueira Aug 15, 2020
d15d446
refactor(opentelemetry-plugin-pg): clarify method signatures
sergioregueira Aug 15, 2020
4292814
feat(opentelemetry-plugin-pg): do not track values by default
sergioregueira Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(opentelemetry-plugin-pg): fix eslint warnings
  • Loading branch information
@sergioregueira
sergioregueira committed Aug 16, 2020
commit 925b9adb7c03c04513645d3ba3c603e89978a59f
2 changes: 1 addition & 1 deletion plugins/node/opentelemetry-plugin-pg/src/pg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export class PostgresPlugin extends BasePlugin<typeof pgTypes> {
return result
.then((result: unknown) => {
// Return a pass-along promise which ends the span and then goes to user's orig resolvers
return new Promise((resolve, _) => {
return new Promise(resolve => {
span.setStatus({ code: CanonicalCode.OK });
span.end();
resolve(result);
Expand Down