Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix excessive memory usage by preventing source-map generation #1419

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Browser tests are running out of heap space using 8+ GB of memory. This PR applies the same fix as in the core repo, preventing source map generation by the istanbul library, but applied in the karma config instead of .nycrc. It looks like here source maps are already generated, and coverage is accurately mapped.

For a detailed description see the original PR in core open-telemetry/opentelemetry-js#3642 and the associated issue open-telemetry/opentelemetry-js#3628

Short description of the changes

  • turn off source-map generation in the loader options, which passes it on to the istanbul instrumenter library.

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1419 (78cae1c) into main (e93a192) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1419   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          14       14           
  Lines         890      890           
  Branches      192      192           
=======================================
  Hits          855      855           
  Misses         35       35           

@pichlermarc pichlermarc marked this pull request as ready for review March 2, 2023 19:35
@pichlermarc pichlermarc requested a review from a team March 2, 2023 19:35
@pichlermarc pichlermarc mentioned this pull request Mar 3, 2023
@dyladan dyladan merged commit 17c3bf1 into open-telemetry:main Mar 3, 2023
@dyladan dyladan deleted the ci/fix-memory-use branch March 3, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants