Add service.instance.id for all resource detectors #2065
Comments
maryliag
changed the title
6 tasks
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…e detection `service.instance.id` is a recommended value. This commit adds it to the alibaba resource detector. It uses the `serial-number` value from the instance metadata, which has the description: ``` The serial number of the instance. Example: 4acd2b47-b328-4762-852f-998**** ``` Which alignes with the definition for `service.instance.id` from [here](open-telemetry/semantic-conventions#312) Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…e detection `service.instance.id` is a recommended value. This commit adds it to the alibaba resource detector. It uses the `serial-number` value from the instance metadata, which has the description: ``` The serial number of the instance. Example: 4acd2b47-b328-4762-852f-998**** ``` Which alignes with the definition for `service.instance.id` from [here](open-telemetry/semantic-conventions#312) Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…ction `service.instance.id` is a recommended value. Implements `service.instance.id` from [here](open-telemetry/semantic-conventions#312). Uses `randomUUID` as is similar implemented on other languages, such as the Java SDK. Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…e detection `service.instance.id` is a recommended value. This commit adds it to the alibaba resource detector. It uses the `serial-number` value from the instance metadata, which has the description: ``` The serial number of the instance. Example: 4acd2b47-b328-4762-852f-998**** ``` Which alignes with the definition for `service.instance.id` from [here](open-telemetry/semantic-conventions#312) Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…e detection `service.instance.id` is a recommended value. This commit adds it to the alibaba resource detector. It uses the `serial-number` value from the instance metadata, which has the description: ``` The serial number of the instance. Example: 4acd2b47-b328-4762-852f-998**** ``` Which alignes with the definition for `service.instance.id` from [here](open-telemetry/semantic-conventions#312) Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
maryliag
added a commit
to maryliag/opentelemetry-js-contrib
that referenced
this issue
Apr 3, 2024
…ction `service.instance.id` is a recommended value. Implements `service.instance.id` from [here](open-telemetry/semantic-conventions#312). Uses `randomUUID` as is similar implemented on other languages, such as the Java SDK. Part Of open-telemetry#2065 Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
|
Closing this, because I couldn't find something better than random for all of them, so instead the SDK itself should be the one setting the value as random, when nothing else is set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe
service.instance.idis a recommended attribute, and some resource detectors are already setting the value, but it's still missing from some.Describe the solution you'd like to see
Set
service.instance.idfor the missing cloud providers detectors:Additional context
I've started the work on this
The text was updated successfully, but these errors were encountered: