-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial relocation of ContextUtils classes. #904
Initial relocation of ContextUtils classes. #904
Conversation
Now they will live within the child `propagation` package, with a prefix based on their cross-cutting concern, to be referenced easily.
api/src/main/java/io/opentelemetry/correlationcontext/propagation/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/propagation/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/propagation/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/trace/propagation/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
.../test/java/io/opentelemetry/correlationcontext/propagation/CorrelationsContextUtilsTest.java
Outdated
Show resolved
Hide resolved
.../test/java/io/opentelemetry/correlationcontext/propagation/CorrelationsContextUtilsTest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/trace/propagation/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/trace/propagation/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
12b924a
to
93c9698
Compare
Updated ;) @bogdandrutu Left a comment, please review. |
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
============================================
- Coverage 84.39% 84.28% -0.11%
+ Complexity 893 890 -3
============================================
Files 119 118 -1
Lines 3165 3163 -2
Branches 271 273 +2
============================================
- Hits 2671 2666 -5
- Misses 379 380 +1
- Partials 115 117 +2
Continue to review full report at Codecov.
|
@open-telemetry/java-approvers This PR has been updated:
|
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/CorrelationsContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/DefaultCorrelationContextManager.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/trace/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/trace/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/opentelemetry/correlationcontext/DefaultCorrelationContextManager.java
Outdated
Show resolved
Hide resolved
Thanks for the feedback @bogdandrutu Please review the latest questions I left, and I will iterate ASAP ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment left to remove the version of the withSpan without the context (same for correlation).
* Initial relocation of ContextUtils classes. Now they will live within the child `propagation` package, with a prefix based on their cross-cutting concern, to be referenced easily.
* Initial relocation of ContextUtils classes. Now they will live within the child `propagation` package, with a prefix based on their cross-cutting concern, to be referenced easily.
Now they will live within their own child
propagation
package (instead ofunsafe
), with a prefix based on their cross-cutting concern, to be referenced easily.NOTE:
Context.Key
instances now don't have a default value, and we provide an actual default when they returnnull
. The reason for this is that, upon Injection, we want to detect whether there's an actual value inContext
:An alternative would be to check against
DefaultSpan.getInvalid()
if we offer such default value along the key.Because of this, we offer
getSpan()
andgetSpanWithDefault()
variants (SpanBuilderSdk
uses the former to easily check thatSpan
is not a no-op instance, for example).I'm open to discuss this detail though.
This has been split from #720