Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gauge from the API #830

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

bogdandrutu
Copy link
Member

Left a TODO to update the comment for Meter (comment is very old).

@jkwatson
Copy link
Contributor

jkwatson commented Feb 6, 2020

looks like a checkstyle failure on the build

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #830 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #830      +/-   ##
============================================
+ Coverage     78.96%   79.05%   +0.09%     
+ Complexity      798      790       -8     
============================================
  Files           106      105       -1     
  Lines          2885     2845      -40     
  Branches        275      273       -2     
============================================
- Hits           2278     2249      -29     
+ Misses          503      493      -10     
+ Partials        104      103       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/io/opentelemetry/sdk/metrics/MeterSdk.java 86.66% <ø> (+10.19%) 10 <0> (ø) ⬇️
...in/java/io/opentelemetry/metrics/DefaultMeter.java 71.18% <ø> (-1.49%) 25 <0> (-6)
...elemetry/opentracingshim/SpanContextShimTable.java 96.42% <0%> (+7.14%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a44a2...e9029f6. Read the comment docs.

Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
@arminru arminru changed the title Remove guage from the API. Remove gauge from the API Feb 7, 2020
@bogdandrutu bogdandrutu merged commit 2dd7612 into open-telemetry:master Feb 7, 2020
@bogdandrutu bogdandrutu deleted the gauge branch February 7, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants