Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "unit" to BaseInstrument #829

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu changed the title Add "unit"to BaseInstrument Add "unit" to BaseInstrument Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #829 into master will increase coverage by 0.21%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #829      +/-   ##
============================================
+ Coverage     78.67%   78.89%   +0.21%     
+ Complexity      798      797       -1     
============================================
  Files           106      106              
  Lines          2856     2885      +29     
  Branches        278      275       -3     
============================================
+ Hits           2247     2276      +29     
+ Misses          505      504       -1     
- Partials        104      105       +1
Impacted Files Coverage Δ Complexity Δ
.../io/opentelemetry/sdk/metrics/LongObserverSdk.java 53.84% <100%> (+10.98%) 2 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 65.71% <100%> (+5.71%) 5 <1> (ø) ⬇️
...o/opentelemetry/sdk/metrics/DoubleObserverSdk.java 53.84% <100%> (+10.98%) 2 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 65.71% <100%> (+5.71%) 5 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 65.71% <100%> (+5.71%) 5 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 65.71% <100%> (+5.71%) 5 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/BaseInstrument.java 30.43% <16.66%> (+5.43%) 1 <1> (ø) ⬇️
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 90.3% <0%> (-1.22%) 44% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b975b...f0d9513. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
@bogdandrutu
Copy link
Member Author

Trivial change, merging now.

@bogdandrutu bogdandrutu merged commit e9a44a2 into open-telemetry:master Feb 6, 2020
@bogdandrutu bogdandrutu deleted the unit branch February 6, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants