Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observer API examples in Javadoc #825

Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Feb 6, 2020

This PR closes #824 aligning the examples in the API documentation with the implementation of the Observer meter.

@codecov-io
Copy link

Codecov Report

Merging #825 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #825      +/-   ##
============================================
- Coverage     79.22%   79.15%   -0.08%     
  Complexity      790      790              
============================================
  Files           104      104              
  Lines          2811     2811              
  Branches        269      269              
============================================
- Hits           2227     2225       -2     
- Misses          481      483       +2     
  Partials        103      103
Impacted Files Coverage Δ Complexity Δ
...elemetry/sdk/trace/export/BatchSpansProcessor.java 89.65% <0%> (-1.73%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65179f8...c08b251. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 54b5b2e into open-telemetry:master Feb 6, 2020
@arminru arminru deleted the observer-api-doc branch February 7, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observer API examples are outdated
5 participants