Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android API level validation #822

Closed
wants to merge 2 commits into from

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Feb 6, 2020

resolves #744

Keep the Java 7 enforcement.
@codecov-io
Copy link

Codecov Report

Merging #822 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #822      +/-   ##
============================================
- Coverage     79.22%   79.08%   -0.15%     
+ Complexity      790      789       -1     
============================================
  Files           104      104              
  Lines          2811     2811              
  Branches        269      269              
============================================
- Hits           2227     2223       -4     
- Misses          481      484       +3     
- Partials        103      104       +1
Impacted Files Coverage Δ Complexity Δ
...elemetry/sdk/trace/export/BatchSpansProcessor.java 89.65% <0%> (-1.73%) 7% <0%> (ø)
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 90.3% <0%> (-1.22%) 44% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65179f8...e296844. Read the comment docs.

@carlosalberto
Copy link
Contributor

Looks great! Wondering why the update in the proto files though.

@jkwatson
Copy link
Contributor Author

jkwatson commented Feb 6, 2020

oh, good call on the protos. I'll revert that bit. It snuck in with my global search and replace.

@jkwatson
Copy link
Contributor Author

jkwatson commented Feb 6, 2020

I'm going to close this and open up another one. I really don't know how to git submodule properly.

@jkwatson jkwatson closed this Feb 6, 2020
@jkwatson jkwatson deleted the remove_android_level_validation branch February 6, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change min java/android version for SDK
3 participants