Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation for Observers #818

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

bogdandrutu
Copy link
Member

No tests yet for the Observers, will add when we add the Callback support.

Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #818 into master will decrease coverage by 0.37%.
The diff coverage is 48.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #818      +/-   ##
============================================
- Coverage     79.04%   78.66%   -0.38%     
- Complexity      785      793       +8     
============================================
  Files           104      107       +3     
  Lines          2811     2855      +44     
  Branches        269      277       +8     
============================================
+ Hits           2222     2246      +24     
- Misses          484      505      +21     
+ Partials        105      104       -1
Impacted Files Coverage Δ Complexity Δ
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 58.62% <ø> (ø) 3 <0> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 58.62% <ø> (ø) 3 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 58.62% <ø> (ø) 3 <0> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 58.62% <ø> (ø) 3 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/BaseInstrument.java 25% <0%> (-5.77%) 1 <0> (-2)
...in/java/io/opentelemetry/sdk/metrics/MeterSdk.java 76.47% <100%> (+11.76%) 10 <2> (+2) ⬆️
...lemetry/sdk/metrics/BaseInstrumentWithBinding.java 100% <100%> (ø) 3 <3> (?)
.../io/opentelemetry/sdk/metrics/LongObserverSdk.java 42.85% <42.85%> (ø) 2 <2> (?)
...o/opentelemetry/sdk/metrics/DoubleObserverSdk.java 42.85% <42.85%> (ø) 2 <2> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2843a1...b972598. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good next step!

@bogdandrutu bogdandrutu merged commit 9f1e87c into open-telemetry:master Feb 6, 2020
@bogdandrutu bogdandrutu deleted the observer branch February 6, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants