Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jaeger example #776

Merged

Conversation

thisthat
Copy link
Member

Resolve #775
@carlosalberto please test if this solves your problem.

@codecov-io
Copy link

Codecov Report

Merging #776 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #776      +/-   ##
============================================
- Coverage     78.84%   78.77%   -0.08%     
+ Complexity      761      760       -1     
============================================
  Files            98       98              
  Lines          2709     2709              
  Branches        255      255              
============================================
- Hits           2136     2134       -2     
- Misses          473      474       +1     
- Partials        100      101       +1
Impacted Files Coverage Δ Complexity Δ
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 90.24% <0%> (-1.22%) 43% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5517dcb...694c6ba. Read the comment docs.

@carlosalberto carlosalberto merged commit 03f3402 into open-telemetry:master Jan 19, 2020
@thisthat thisthat deleted the fix_jaeger_example branch January 20, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger example not working
3 participants