Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test helper for auto configure #6496

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Jun 4, 2024

  • it uses optional dependencies
  • awaitility only for traces can probably be improved
  • no tests yet

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 50.46729% with 53 lines in your changes missing coverage. Please review.

Project coverage is 90.38%. Comparing base (56c1879) to head (606c931).
Report is 15 commits behind head on main.

Current head 606c931 differs from pull request most recent head 5782ca6

Please upload reports for the commit 5782ca6 to get more accurate results.

Files Patch % Lines
...metry/sdk/testing/sdk/InMemoryComponentLoader.java 0.00% 27 Missing ⚠️
...esting/sdk/AutoConfiguredOpenTelemetryTesting.java 0.00% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6496      +/-   ##
============================================
- Coverage     90.62%   90.38%   -0.24%     
+ Complexity     6243     6233      -10     
============================================
  Files           683      682       -1     
  Lines         18701    18715      +14     
  Branches       1842     1845       +3     
============================================
- Hits          16948    16916      -32     
- Misses         1197     1242      +45     
- Partials        556      557       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member

Would you be willing to present this at the Java SIG? It's not clear to me what the goal of this is and I think a synchronous conversation could help clear it up 🙂. Alternatively, a more detailed description could clarify the intent.

@zeitlinger
Copy link
Member Author

Would you be willing to present this at the Java SIG?

yes, let's do that

@jack-berg
Copy link
Member

@zeitlinger per our conversation, see this link for an example of how we setup OTLP receivers in tests and make assertions against the payloads: https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/src/testFullConfig/java/io/opentelemetry/sdk/autoconfigure/FullConfigTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants