Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward slash to InstrumentName log message #6343

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

breedx-splk
Copy link
Contributor

This came up in a real-world situation where the instrument name was failing for a different reason, but contained a forward slash, leading us to believe that was the cause. This adds the forward slash as an allowable character to the log message, and is in keeping with the spec.

@breedx-splk breedx-splk requested a review from a team April 3, 2024 16:12
@breedx-splk
Copy link
Contributor Author

Oooh, the javadoc in the Meter.xxxBuilder() methods are also missing forward slash in at least one case.

@jack-berg
Copy link
Member

jack-berg commented Apr 3, 2024

Oooh, the javadoc in the Meter.xxxBuilder() methods are also missing forward slash in at least one case.

👍 will wait for the javadoc updates before merging

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (1dde255) to head (cb0be6a).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6343      +/-   ##
============================================
- Coverage     91.11%   91.09%   -0.02%     
- Complexity     5760     5772      +12     
============================================
  Files           627      627              
  Lines         16799    16852      +53     
  Branches       1718     1720       +2     
============================================
+ Hits          15306    15351      +45     
- Misses          998     1006       +8     
  Partials        495      495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg jack-berg merged commit 6c7770b into open-telemetry:main Apr 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants