-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Implement Metric Producer specification #5678
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges with the prometheus exporter
dashpole
force-pushed
the
metric_producer
branch
from
August 3, 2023 19:05
9c99c06
to
39b347b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5678 +/- ##
============================================
- Coverage 91.31% 90.61% -0.70%
- Complexity 4978 4988 +10
============================================
Files 554 555 +1
Lines 14731 14855 +124
Branches 1376 1388 +12
============================================
+ Hits 13451 13461 +10
- Misses 884 969 +85
- Partials 396 425 +29
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricproducer
It includes open-telemetry/opentelemetry-specification#3613, as producers are passed to readers as configuration, rather than via a registration method.
The tricky part was how to handle Resource (see open-telemetry/opentelemetry-specification#3636). This is tricky because getResource is part of MetricData, but we would rather the OpenCensus shim not need to understand resource. In this PoC, i've opted to split the MetricProducer interface into two interfaces: SdkMetricProducer, and MetricProducer.
Alternatively, the produce() function on MetricProducer could accept Resource as a parameter, and return MetricData. That would introduce less of an API surface, but could be misused.
example usage:
TODOs:
@jack-berg @jsuereth