Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete MapCounter alternative histogram bucket implementation #5047

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

jack-berg
Copy link
Member

The exponential histogram aggregation has abstractions that allow you plug in alternative bucket counter implementations. Currently there are two: AdaptingCircularBufferCounter (the default) and MapCounter. MapCounter is only usable in JMH tests (i.e. users can't opt in to using it even with internal APIs), and its considerably slower than AdaptingCircularBufferCounter.

Retaining MapCounter and the abstractions that allow it to be used bloats the codebase and makes the exponential histogram implementation harder to reason about. It was a useful tool for evaluating performance but it served its purpose and its time to remove it.

@jack-berg jack-berg requested a review from a team December 16, 2022 14:53
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 91.25% // Head: 91.27% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (d255987) compared to base (57595b0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5047      +/-   ##
============================================
+ Coverage     91.25%   91.27%   +0.02%     
+ Complexity     4894     4866      -28     
============================================
  Files           552      549       -3     
  Lines         14481    14394      -87     
  Branches       1386     1375      -11     
============================================
- Hits          13214    13138      -76     
+ Misses          878      870       -8     
+ Partials        389      386       -3     
Impacted Files Coverage Δ
...ternal/aggregator/ExponentialHistogramIndexer.java 100.00% <ø> (ø)
...internal/view/ExponentialHistogramAggregation.java 100.00% <ø> (ø)
...rnal/aggregator/AdaptingCircularBufferCounter.java 90.56% <100.00%> (ø)
...rics/internal/aggregator/AdaptingIntegerArray.java 93.75% <100.00%> (ø)
...gregator/DoubleExponentialHistogramAggregator.java 96.66% <100.00%> (-0.14%) ⬇️
.../aggregator/DoubleExponentialHistogramBuckets.java 83.33% <100.00%> (-0.31%) ⬇️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants