Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Shim: Log invalid arguments instead of throwing exceptions. #5012

Merged
merged 1 commit into from
Dec 3, 2022
Merged

OpenTracing Shim: Log invalid arguments instead of throwing exceptions. #5012

merged 1 commit into from
Dec 3, 2022

Conversation

carlosalberto
Copy link
Contributor

Fixes #5005

cc @zeitlinger

@carlosalberto carlosalberto requested a review from a team December 2, 2022 14:28
@carlosalberto carlosalberto changed the title OpenTracing Shim: Log invalid arguments rather than throwing exceptions. OpenTracing Shim: Log invalid arguments instead of throwing exceptions. Dec 2, 2022
@jkwatson jkwatson merged commit 88a7781 into open-telemetry:main Dec 3, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
@carlosalberto @dmarkwat
Log invalid arguments rather than throwing exceptions. (open-telemetr…
fc3754c 
…y#5012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTracing Shim: Ignore invalid arguments
3 participants
@carlosalberto @jack-berg @jkwatson