-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generateBuildSubstitutions task to bom projects. #3653
Add generateBuildSubstitutions task to bom projects. #3653
Conversation
This is a convenience task that can be used to generate a code snippet that can be copy-pasted for use in composite builds.
Codecov Report
@@ Coverage Diff @@
## main #3653 +/- ##
============================================
+ Coverage 87.63% 88.96% +1.32%
- Complexity 3678 3692 +14
============================================
Files 438 442 +4
Lines 11707 11562 -145
Branches 1128 1113 -15
============================================
+ Hits 10260 10286 +26
+ Misses 1078 898 -180
- Partials 369 378 +9
Continue to review full report at Codecov.
|
This seems reasonable to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me.
I was just about to type the exact same letters!
@@ -59,6 +59,12 @@ nexusPublishing { | |||
} | |||
} | |||
|
|||
// The BOM projects register dependent tasks that actually do the generating. | |||
tasks.register("generateBuildSubstitutions") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to copy-paste this.
1. Run `./gradlew generateBuildSubstitutions` | ||
2. Two files named `build/substitutions.gradle.kts` are generated in the bom and bom-alpha project's | ||
directory, containing substitutions for the stable and alpha projects respectively. | ||
3. Copy & paste the content of these files to a new `settings.gradle.kts` or the one where you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still cumbersome. If anyone knows a better format I could generate that could be used in a more straight-forward way, that would be appreciated.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This is an alternative to #3603 (which I'd still prefer).
Since there was no agreement on renaming the projects, we can at least save ourselves the trouble of writing the substitutions for an included build by hand every time and let gradle to it in a semi-automated way.
This adds the
generateBuildSubstitutions
task to the bom projects, which is a convenience task that can be used togenerate a code snippet that can be copy-pasted
for use in composite builds.
Output for (stable) bom:
Output for bom-alpha:
If this approach seems right, I'll extend the README to document how to use this to create a composite build.