-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTracingShimBuilder class and test #3129
Add OpenTracingShimBuilder class and test #3129
Conversation
private OpenTracingPropagators propagators = OpenTracingPropagators.builder().build(); | ||
|
||
/** Returns a new {@code OpenTracingShimBuilder} instance. */ | ||
public static OpenTracingShimBuilder builder(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our pattern for this is to have this method live in the OpenTracingShim
class, rather than here.
@@ -11,6 +11,9 @@ | |||
import io.opentelemetry.api.trace.TracerProvider; | |||
|
|||
/** | |||
* This class is deprecated. Please Use {@link OpenTracingShimBuilder} instead to create an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I wonder if it would be good to keep this class, just with the builder()
method on it, to keep the patterns the same as they are in the rest of the code. It does make this class a bit anemic, but it was already that way. :)
@IrisTuntun are you planning on picking this up again at some point? |
@jkwatson I had originally suggested holding off on this until the spec issue, which hasn't gotten any input on yet |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Add
OpenTracingShimBuilder
class to simplify OpenTracingShim creational patterns. Future use cases should not depend onOpenTracingShim
any more.resolve #3084