Add OpenTracingShimBuilder class and test #3129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrisTuntun
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
jkwatson
reviewed
Apr 7, 2021
| private OpenTracingPropagators propagators = OpenTracingPropagators.builder().build(); | ||
|
|
||
| /** Returns a new {@code OpenTracingShimBuilder} instance. */ | ||
| public static OpenTracingShimBuilder builder(){ |
There was a problem hiding this comment.
Our pattern for this is to have this method live in the OpenTracingShim class, rather than here.
jkwatson
reviewed
Apr 7, 2021
| @@ -11,6 +11,9 @@ | |||
| import io.opentelemetry.api.trace.TracerProvider; | |||
|
|
|||
| /** | |||
| * This class is deprecated. Please Use {@link OpenTracingShimBuilder} instead to create an | |||
There was a problem hiding this comment.
Hmm. I wonder if it would be good to keep this class, just with the builder() method on it, to keep the patterns the same as they are in the rest of the code. It does make this class a bit anemic, but it was already that way. :)
|
@IrisTuntun are you planning on picking this up again at some point? |
|
@jkwatson I had originally suggested holding off on this until the spec issue, which hasn't gotten any input on yet |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
OpenTracingShimBuilderclass to simplify OpenTracingShim creational patterns. Future use cases should not depend onOpenTracingShimany more.resolve #3084