Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update in CONTRIBUTING.md, additions on PR review #3082

Merged
merged 5 commits into from
Apr 2, 2021
Merged

Update in CONTRIBUTING.md, additions on PR review #3082

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a45252
Update CONTRIBUTING.md
harshita19244 Mar 31, 2021
ef58ad6
Update CONTRIBUTING.md
harshita19244 Apr 1, 2021
d86c0df
Fixed Windows bug with gradle
harshita19244 Apr 2, 2021
4a08d87
Update CONTRIBUTING.md
harshita19244 Apr 2, 2021
ee050e1
Update CONTRIBUTING.md
harshita19244 Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ with the `check` task.
```bash
$ ./gradlew check
```
## PR Review
After you submit a PR, it will be reviewed by the project maintainers and approvers. Not all maintainers need to review a
particular PR, but merging to the base branch is authorized to restricted members (administrators).

## Style guideline

Expand Down Expand Up @@ -134,4 +137,4 @@ The OTLP proto dependency version is defined [here](proto/build.gradle). To bump
1. Find the latest release version [here](https://github.com/open-telemetry/opentelemetry-proto/releases/latest)
2. Download the zip source code archive
3. Run `shasum -a 256 ~/path/to/downloaded.zip` to compute its checksum
4. Update `protoVersion` and `protoChecksum` in the build file with the new version and checksum
4. Update `protoVersion` and `protoChecksum` in the build file with the new version and checksum