Ignore null / invalid spancontext and handle null attributes for links. #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
jkwatson
reviewed
Mar 5, 2021
| if (spanContext == null || !spanContext.isValid()) { | ||
| return this; | ||
| } | ||
| if (!spanContext.isValid()) { |
There was a problem hiding this comment.
this is redundant with the check above, correct?
bogdandrutu
reviewed
Mar 6, 2021
| @@ -83,12 +83,24 @@ public SpanBuilder setSpanKind(SpanKind spanKind) { | |||
|
|
|||
| @Override | |||
| public SpanBuilder addLink(SpanContext spanContext) { | |||
| if (spanContext == null || !spanContext.isValid()) { | |||
| return this; | |||
| } | |||
| addLink(LinkData.create(spanContext)); | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public SpanBuilder addLink(SpanContext spanContext, Attributes attributes) { | |||
There was a problem hiding this comment.
Should we also document in the API, same as you did in the specs:
"Implementation MAY ignore ...."
added 2 commits
March 7, 2021 14:43
bogdandrutu
approved these changes
Mar 7, 2021
jkwatson
approved these changes
Mar 7, 2021
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2955
Spec PR :open-telemetry/opentelemetry-specification#1492