update the QUICKSTART for 0.15.0 #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
anuraaga
approved these changes
Jan 30, 2021
| SdkTracerProvider tracerProvider = SdkTracerProvider.builder() | ||
| .setTraceConfig(half) | ||
| .setSampler(Sampler.alwaysOn()) |
QUICKSTART.md
Outdated
| @@ -401,11 +394,11 @@ in bulk. Multiple Span processors can be configured to be active at the same tim | |||
| ```java | |||
| SdkTracerProvider tracerProvider = SdkTracerProvider.builder() | |||
| .addSpanProcessor( | |||
| MultiSpanProcessor.create(Arrays.asList( | |||
| SpanProcessor.composite( | |||
There was a problem hiding this comment.
I guess multiple calls to addSpanProcessor would be more natural, and ends up with us creating the composite
QUICKSTART.md
Outdated
| JaegerGrpcSpanExporter jaegerExporter = JaegerGrpcSpanExporter.builder() | ||
| .setServiceName("example").setChannel(jaegerChannel).setDeadline(30000) | ||
| .build() | ||
| .setChannel(jaegerChannel).setTimeout(30, TimeUnit.SECONDS) |
There was a problem hiding this comment.
How about updating this to setEndpoint("localhost:3336")?
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
bogdandrutu
reviewed
Feb 1, 2021
QUICKSTART.md
Outdated
Comment on lines
125
to
134
| void a() { | ||
| Span parentSpan = tracer.spanBuilder("a").startSpan(); | ||
| void c() { | ||
| Span parentSpan = tracer.spanBuilder("c").startSpan(); | ||
| try(Scope scope = parentSpan.makeCurrent()) { | ||
| b(); | ||
| d(); | ||
| } finally { | ||
| parentSpan.end(); | ||
| } | ||
| } | ||
| void b() { | ||
| Span childSpan = tracer.spanBuilder("b") | ||
| void d() { | ||
| Span childSpan = tracer.spanBuilder("d") |
There was a problem hiding this comment.
Please avoid 1 character function names in examples, also using b and d makes things even harder to see.
There was a problem hiding this comment.
I thought you liked c! ;)
I'll clean this up.
There was a problem hiding this comment.
By the way, the only reason this even got touched is that I'm starting to think about auto-generating these docs from a template java file, and I needed it all to compile locally. :)
Codecov Report
@@ Coverage Diff @@
## main #2615 +/- ##
===========================================
+ Coverage 0 87.64% +87.64%
- Complexity 0 2633 +2633
===========================================
Files 0 315 +315
Lines 0 8733 +8733
Branches 0 892 +892
===========================================
+ Hits 0 7654 +7654
- Misses 0 791 +791
- Partials 0 288 +288
Continue to review full report at Codecov.
|
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-java
that referenced
this pull request
Feb 7, 2021
This reverts commit 13effbd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.