-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the QUICKSTART for 0.15.0 #2615
Conversation
SdkTracerProvider tracerProvider = SdkTracerProvider.builder() | ||
.setTraceConfig(half) | ||
.setSampler(Sampler.alwaysOn()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
QUICKSTART.md
Outdated
@@ -401,11 +394,11 @@ in bulk. Multiple Span processors can be configured to be active at the same tim | |||
```java | |||
SdkTracerProvider tracerProvider = SdkTracerProvider.builder() | |||
.addSpanProcessor( | |||
MultiSpanProcessor.create(Arrays.asList( | |||
SpanProcessor.composite( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess multiple calls to addSpanProcessor
would be more natural, and ends up with us creating the composite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
QUICKSTART.md
Outdated
JaegerGrpcSpanExporter jaegerExporter = JaegerGrpcSpanExporter.builder() | ||
.setServiceName("example").setChannel(jaegerChannel).setDeadline(30000) | ||
.build() | ||
.setChannel(jaegerChannel).setTimeout(30, TimeUnit.SECONDS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about updating this to setEndpoint("localhost:3336")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
QUICKSTART.md
Outdated
void a() { | ||
Span parentSpan = tracer.spanBuilder("a").startSpan(); | ||
void c() { | ||
Span parentSpan = tracer.spanBuilder("c").startSpan(); | ||
try(Scope scope = parentSpan.makeCurrent()) { | ||
b(); | ||
d(); | ||
} finally { | ||
parentSpan.end(); | ||
} | ||
} | ||
void b() { | ||
Span childSpan = tracer.spanBuilder("b") | ||
void d() { | ||
Span childSpan = tracer.spanBuilder("d") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid 1 character function names in examples, also using b
and d
makes things even harder to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you liked c! ;)
I'll clean this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, the only reason this even got touched is that I'm starting to think about auto-generating these docs from a template java file, and I needed it all to compile locally. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## main #2615 +/- ##
===========================================
+ Coverage 0 87.64% +87.64%
- Complexity 0 2633 +2633
===========================================
Files 0 315 +315
Lines 0 8733 +8733
Branches 0 892 +892
===========================================
+ Hits 0 7654 +7654
- Misses 0 791 +791
- Partials 0 288 +288
Continue to review full report at Codecov.
|
This reverts commit 13effbd.
No description provided.