Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace git submodules for protos with download of archive file. #2160

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

anuraaga
Copy link
Contributor

No description provided.

dependsOn(downloadProtoArchive)
src protoArchivePath
algorithm "SHA-256"
// To generate checksum, download the file and run "shasum -a 256 ~/path/to/vfoo.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we include something in the CONTRIBUTING.md about the process of updating the proto version?

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my hero!

@anuraaga
Copy link
Contributor Author

anuraaga commented Dec 1, 2020

Thanks for reminder that I could also remove a lot of cruft!

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2160 (d5505a9) into master (ebb68da) will increase coverage by 85.33%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2160       +/-   ##
=============================================
+ Coverage          0   85.33%   +85.33%     
- Complexity        0     2135     +2135     
=============================================
  Files             0      245      +245     
  Lines             0     8181     +8181     
  Branches          0      903      +903     
=============================================
+ Hits              0     6981     +6981     
- Misses            0      869      +869     
- Partials          0      331      +331     
Impacted Files Coverage Δ Complexity Δ
...y/sdk/trace/samplers/TraceIdRatioBasedSampler.java 100.00% <0.00%> (ø) 10.00% <0.00%> (?%)
.../io/opentelemetry/sdk/OpenTelemetrySdkFactory.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...opentelemetry/sdk/testing/assertj/TraceAssert.java 86.66% <0.00%> (ø) 6.00% <0.00%> (?%)
...emetry/sdk/metrics/common/InstrumentValueType.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...ntelemetry/exporter/zipkin/ZipkinSpanExporter.java 90.22% <0.00%> (ø) 31.00% <0.00%> (?%)
...pentelemetry/sdk/metrics/LongValueObserverSdk.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...metry/sdk/metrics/export/IntervalMetricReader.java 87.50% <0.00%> (ø) 4.00% <0.00%> (?%)
...java/io/opentelemetry/api/common/AttributeKey.java 100.00% <0.00%> (ø) 8.00% <0.00%> (?%)
.../opentelemetry/sdk/metrics/AbstractInstrument.java 91.66% <0.00%> (ø) 7.00% <0.00%> (?%)
.../java/io/opentelemetry/context/DefaultContext.java 100.00% <0.00%> (ø) 6.00% <0.00%> (?%)
... and 235 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb68da...d5505a9. Read the comment docs.

@anuraaga anuraaga merged commit c3261b4 into open-telemetry:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants