-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace git submodules for protos with download of archive file. #2160
Conversation
proto/build.gradle
Outdated
dependsOn(downloadProtoArchive) | ||
src protoArchivePath | ||
algorithm "SHA-256" | ||
// To generate checksum, download the file and run "shasum -a 256 ~/path/to/vfoo.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we include something in the CONTRIBUTING.md about the process of updating the proto version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my hero!
Thanks for reminder that I could also remove a lot of cruft! |
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
=============================================
+ Coverage 0 85.33% +85.33%
- Complexity 0 2135 +2135
=============================================
Files 0 245 +245
Lines 0 8181 +8181
Branches 0 903 +903
=============================================
+ Hits 0 6981 +6981
- Misses 0 869 +869
- Partials 0 331 +331
Continue to review full report at Codecov.
|
No description provided.