Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial list of best practices to follow in our project #1925

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: John Watson <jkwatson@gmail.com>
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1925 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1925      +/-   ##
============================================
- Coverage     86.63%   86.61%   -0.02%     
- Complexity     1500     1502       +2     
============================================
  Files           184      184              
  Lines          5663     5664       +1     
  Branches        582      582              
============================================
  Hits           4906     4906              
  Misses          551      551              
- Partials        206      207       +1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/opentelemetry/api/baggage/Baggage.java 100.00% <100.00%> (ø) 6.00 <2.00> (+2.00)
...ava/io/opentelemetry/api/baggage/BaggageUtils.java 100.00% <100.00%> (ø) 6.00 <5.00> (-1.00)
...io/opentelemetry/api/baggage/ImmutableBaggage.java 96.77% <100.00%> (ø) 17.00 <0.00> (ø)
.../api/baggage/propagation/W3CBaggagePropagator.java 93.18% <100.00%> (ø) 15.00 <0.00> (ø)
.../io/opentelemetry/opentracingshim/Propagation.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...lemetry/context/PersistentHashArrayMappedTrie.java 44.54% <0.00%> (-0.91%) 4.00% <0.00%> (ø%)
...ain/java/io/opentelemetry/context/LazyStorage.java 88.46% <0.00%> (ø) 9.00% <0.00%> (ø%)
.../java/io/opentelemetry/context/DefaultContext.java 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
...va/io/opentelemetry/opentracingshim/TraceShim.java 100.00% <0.00%> (ø) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604aee2...726ff76. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
@bogdandrutu bogdandrutu merged commit 75d87f4 into open-telemetry:master Oct 31, 2020
@bogdandrutu bogdandrutu deleted the bestpractices branch October 31, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants