Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TraceConfig configuration option names #1824

Merged
merged 3 commits into from
Oct 18, 2020

Conversation

dengliming
Copy link
Member

resolves #1802

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #1824 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1824      +/-   ##
============================================
+ Coverage     85.13%   85.16%   +0.03%     
  Complexity     1437     1437              
============================================
  Files           177      177              
  Lines          5583     5583              
  Branches        578      578              
============================================
+ Hits           4753     4755       +2     
+ Misses          627      626       -1     
+ Partials        203      202       -1     
Impacted Files Coverage Δ Complexity Δ
...io/opentelemetry/sdk/trace/config/TraceConfig.java 95.00% <100.00%> (ø) 6.00 <0.00> (ø)
...y/sdk/metrics/aggregator/DoubleMinMaxSumCount.java 100.00% <0.00%> (+4.08%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe07cff...9bd7798. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson jkwatson merged commit fbfba34 into open-telemetry:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TraceConfig configuration option names
3 participants