-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove getCurrentContext and withSpan from Tracer #1809
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
api/src/main/java/io/opentelemetry/trace/TracingContextUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
============================================
+ Coverage 84.58% 84.64% +0.06%
+ Complexity 1431 1427 -4
============================================
Files 177 177
Lines 5554 5550 -4
Branches 578 578
============================================
Hits 4698 4698
+ Misses 649 646 -3
+ Partials 207 206 -1
Continue to review full report at Codecov.
|
LGTM. Now that this will be the official way, I feel like we should do a follow up to rename |
Shouldn't we just move TracingContextUtils to static Span interface methods? Or even default Span interface methods where it makes sense. |
I think this is a topic of conversation in #1807 |
I hate this change, by the way. It makes the Tracer into something silly and nearly useless. It should be called SpanFactory. :( |
This reverts commit b73a063.
Updates #1807
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com