Remove getCurrentContext and withSpan from Tracer

[bogdandrutu]

Updates #1807

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #1809 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1809      +/-   ##
============================================
+ Coverage     84.58%   84.64%   +0.06%     
+ Complexity     1431     1427       -4     
============================================
  Files           177      177              
  Lines          5554     5550       -4     
  Branches        578      578              
============================================
  Hits           4698     4698              
+ Misses          649      646       -3     
+ Partials        207      206       -1     

Impacted Files	Coverage Δ	Complexity Δ
...ain/java/io/opentelemetry/trace/DefaultTracer.java	100.00% <ø> (ø)	3.00 <0.00> (-2.00)
api/src/main/java/io/opentelemetry/trace/Span.java	100.00% <ø> (ø)	5.00 <0.00> (ø)
...va/io/opentelemetry/trace/TracingContextUtils.java	100.00% <ø> (ø)	7.00 <0.00> (ø)
.../src/main/java/io/opentelemetry/context/Scope.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...ain/java/io/opentelemetry/sdk/trace/TracerSdk.java	100.00% <ø> (ø)	4.00 <0.00> (-2.00)
...pentelemetry/opentracingshim/ScopeManagerShim.java	81.81% <100.00%> (ø)	5.00 <2.00> (ø)
...lemetry/context/PersistentHashArrayMappedTrie.java	55.45% <0.00%> (+3.63%)	4.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0f91b...1c9e742. Read the comment docs.

[carlosalberto]

LGTM. Now that this will be the official way, I feel like we should do a follow up to rename TracingContextUtils to something more friendly ;)

[Oberon00]

Shouldn't we just move TracingContextUtils to static Span interface methods? Or even default Span interface methods where it makes sense.

[jkwatson]

Shouldn't we just move TracingContextUtils to static Span interface methods? Or even default Span interface methods where it makes sense.

I think this is a topic of conversation in #1807

[jkwatson]

I hate this change, by the way. It makes the Tracer into something silly and nearly useless. It should be called SpanFactory. :(