Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename newBuilder to builder for consistency. #1790

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

anuraaga
Copy link
Contributor

We currently are not consistent with whether we use newBuilder or builder for a builder factory. This consolidates on builder, similar to Guava and slightly recommended by AutoValue.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1790 into master will decrease coverage by 0.01%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1790      +/-   ##
============================================
- Coverage     85.94%   85.92%   -0.02%     
+ Complexity     1379     1378       -1     
============================================
  Files           166      166              
  Lines          5307     5307              
  Branches        549      549              
============================================
- Hits           4561     4560       -1     
  Misses          551      551              
- Partials        195      196       +1     
Impacted Files Coverage Δ Complexity Δ
...metry/exporters/inmemory/InMemorySpanExporter.java 95.45% <ø> (ø) 7.00 <0.00> (ø)
...metry/exporters/jaeger/JaegerGrpcSpanExporter.java 76.54% <ø> (ø) 4.00 <0.00> (ø)
...lemetry/exporters/otlp/OtlpGrpcMetricExporter.java 53.93% <0.00%> (ø) 6.00 <0.00> (ø)
...telemetry/exporters/otlp/OtlpGrpcSpanExporter.java 71.42% <0.00%> (ø) 5.00 <0.00> (ø)
...etry/exporters/prometheus/PrometheusCollector.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...telemetry/exporters/zipkin/ZipkinSpanExporter.java 87.96% <ø> (ø) 30.00 <0.00> (ø)
...o/opentelemetry/extensions/trace/MessageEvent.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/io/opentelemetry/SendTraceToJaeger.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 89.18% <ø> (ø) 8.00 <0.00> (ø)
...elemetry/sdk/trace/export/SimpleSpanProcessor.java 92.30% <ø> (ø) 12.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939d1b8...3866cc6. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Consistency is important in the API to reduce confusion.

@jkwatson jkwatson merged commit e2b5245 into open-telemetry:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants