Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the ValueObserver instruments to use the LastValue aggegration. #1689

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Sep 23, 2020

See this spec update: open-telemetry/opentelemetry-specification#984

Resolves #1780

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1689 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1689      +/-   ##
============================================
- Coverage     85.34%   85.27%   -0.08%     
  Complexity     1352     1352              
============================================
  Files           165      165              
  Lines          5242     5242              
  Branches        539      539              
============================================
- Hits           4474     4470       -4     
- Misses          570      572       +2     
- Partials        198      200       +2     
Impacted Files Coverage Δ Complexity Δ
...ava/io/opentelemetry/sdk/metrics/ViewRegistry.java 63.63% <ø> (ø) 6.00 <0.00> (ø)
...o/opentelemetry/sdk/metrics/view/Aggregations.java 76.78% <0.00%> (ø) 4.00 <0.00> (ø)
...try/sdk/metrics/aggregator/LongMinMaxSumCount.java 95.91% <0.00%> (-4.09%) 6.00% <0.00%> (ø%)
...y/sdk/metrics/aggregator/DoubleMinMaxSumCount.java 95.91% <0.00%> (-4.09%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7f7f0...c468f40. Read the comment docs.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the Java maintainers meeting. This is partially fixing the issue because our current MetricData does not reflect the latest changes in OTLP and we should produce Gauge for this. Do we want to go ahead with this? That means we will have another breaking change soon when Gauge will be the correct result.

@jkwatson
Copy link
Contributor Author

I think this is the right change for the current released version of OTLP, yes? I think it's fine to address the OTLP changes as a separate issue, once it gets released.

@bogdandrutu
Copy link
Member

@jkwatson
Copy link
Contributor Author

jkwatson commented Oct 1, 2020

@jkwatson not really, https://github.com/open-telemetry/opentelemetry-java/blob/master/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/MetricAdapter.java#L117

This will be exported as non-monotonic updown sum I believe which is wrong.

hmm. yeah, you're right. :(

@jkwatson
Copy link
Contributor Author

@jkwatson not really, https://github.com/open-telemetry/opentelemetry-java/blob/master/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/MetricAdapter.java#L117
This will be exported as non-monotonic updown sum I believe which is wrong.

hmm. yeah, you're right. :(

#1786 to track getting that fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ValueObserver to have LastValue as default aggregation
3 participants