-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the ValueObserver instruments to use the LastValue aggegration. #1689
Convert the ValueObserver instruments to use the LastValue aggegration. #1689
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1689 +/- ##
============================================
- Coverage 85.34% 85.27% -0.08%
Complexity 1352 1352
============================================
Files 165 165
Lines 5242 5242
Branches 539 539
============================================
- Hits 4474 4470 -4
- Misses 570 572 +2
- Partials 198 200 +2
Continue to review full report at Codecov.
|
0633bd8
to
682dcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the Java maintainers meeting. This is partially fixing the issue because our current MetricData does not reflect the latest changes in OTLP and we should produce Gauge for this. Do we want to go ahead with this? That means we will have another breaking change soon when Gauge will be the correct result.
I think this is the right change for the current released version of OTLP, yes? I think it's fine to address the OTLP changes as a separate issue, once it gets released. |
@jkwatson not really, https://github.com/open-telemetry/opentelemetry-java/blob/master/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/MetricAdapter.java#L117 This will be exported as non-monotonic updown sum I believe which is wrong. |
hmm. yeah, you're right. :( |
682dcb2
to
c468f40
Compare
#1786 to track getting that fixed. |
See this spec update: open-telemetry/opentelemetry-specification#984
Resolves #1780