Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'HttpTextFormat' to 'TextMapPropagator' #1586

Merged
merged 4 commits into from
Aug 26, 2020

Conversation

malafeev
Copy link
Contributor

fix #1581

Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1586 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1586      +/-   ##
============================================
+ Coverage     91.62%   91.67%   +0.05%     
  Complexity      979      979              
============================================
  Files           116      116              
  Lines          3533     3533              
  Branches        307      307              
============================================
+ Hits           3237     3239       +2     
+ Misses          204      203       -1     
+ Partials         92       91       -1     
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/opentelemetry/OpenTelemetry.java 98.21% <100.00%> (ø) 22.00 <0.00> (ø)
...ntelemetry/trace/propagation/HttpTraceContext.java 95.78% <100.00%> (ø) 25.00 <1.00> (ø)
...y/sdk/metrics/aggregator/DoubleMinMaxSumCount.java 100.00% <0.00%> (+3.92%) 6.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e87a69...4c1ba35. Read the comment docs.

@jkwatson
Copy link
Contributor

Can you add an entry to the "Unreleased" section of the CHANGELOG for this, since it's a breaking API change? Thanks!

Sergei Malafeev added 2 commits August 26, 2020 15:25
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
@malafeev
Copy link
Contributor Author

@jkwatson added entry to changelog

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkwatson jkwatson merged commit 8858220 into open-telemetry:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename HttpTextPropagator to TextMapPropagator.
4 participants