-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout fix in OTLP exporters #1585
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1585 +/- ##
============================================
+ Coverage 91.62% 91.70% +0.08%
- Complexity 979 980 +1
============================================
Files 116 116
Lines 3533 3533
Branches 307 307
============================================
+ Hits 3237 3240 +3
+ Misses 204 203 -1
+ Partials 92 90 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh my bad - possible to add a test?
Added test |
Just in case I remind that this and #1579 are required to let instrumentation upgrade to the latest otel-java version. And we need that to move forward |
withDeadlineAfter
sets deadline from the time of its call. Which means that is has to be called write before the actual call toexport
.