Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout fix in OTLP exporters #1585

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Aug 25, 2020

withDeadlineAfter sets deadline from the time of its call. Which means that is has to be called write before the actual call to export.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1585 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1585      +/-   ##
============================================
+ Coverage     91.62%   91.70%   +0.08%     
- Complexity      979      980       +1     
============================================
  Files           116      116              
  Lines          3533     3533              
  Branches        307      307              
============================================
+ Hits           3237     3240       +3     
+ Misses          204      203       -1     
+ Partials         92       90       -2     
Impacted Files Coverage Δ Complexity Δ
...y/sdk/metrics/aggregator/DoubleMinMaxSumCount.java 100.00% <0.00%> (+3.92%) 6.00% <0.00%> (ø%)
...k/extensions/trace/jaeger/sampler/RateLimiter.java 100.00% <0.00%> (+5.88%) 5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e87a69...ee773ab. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh my bad - possible to add a test?

@iNikem
Copy link
Contributor Author

iNikem commented Aug 25, 2020

Added test

@iNikem
Copy link
Contributor Author

iNikem commented Aug 25, 2020

Just in case I remind that this and #1579 are required to let instrumentation upgrade to the latest otel-java version. And we need that to move forward

@jkwatson jkwatson merged commit ff88c88 into open-telemetry:master Aug 25, 2020
@iNikem iNikem deleted the otlp-timeout branch August 26, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants