Enable errorprone's ExpectedExceptionChecker #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Since we migrated to a newer Junit (even later Junit 4 versions would have had assertThrows) and Java 8, we can use assertThrows.
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
=========================================
Coverage 92.33% 92.33%
Complexity 951 951
=========================================
Files 117 117
Lines 3380 3380
Branches 281 281
=========================================
Hits 3121 3121
Misses 172 172
Partials 87 87 Continue to review full report at Codecov.
|
carlosalberto
approved these changes
Aug 5, 2020
jkwatson
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we migrated to a newer Junit (even later Junit 4 versions would have had assertThrows; AssertJ has assertThatExceptionOfType().isThrownBy) and Java 8, we can use assertThrows.
I think the actual refactoring was already done in #1489 by @anuraaga (thank you!), so this only needs to re-enable the warning.