Enable errorprone's ExpectedExceptionChecker #1508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we migrated to a newer Junit (even later Junit 4 versions would have had assertThrows; AssertJ has assertThatExceptionOfType().isThrownBy) and Java 8, we can use assertThrows.
I think the actual refactoring was already done in #1489 by @anuraaga (thank you!), so this only needs to re-enable the warning.